Fix chunk force ticking

[Matyrobbrt]

In 1.21.2, Mojang changed the previous chunk ticking code. Instead of iterating all known chunks and checking if each one should be ticked, it now uses a chunk manager that's constantly based on the location of players.

This means that our previous code which simply adds a check on the ticking candidates is no longer feasible, as chunks situated far out from players will not even be considered candidates to begin with. The new method adds each force ticked chunk to the list of final candidates manually, checking if the chunk is already in the list.

Fixes #1702

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 4b40df59770ede6c0f7518a7e99d748e1ec1f99c.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:testframework:21.4.5-beta-pr-1738-gh-1702
• 📦 net.neoforged:neoforge:21.4.5-beta-pr-1738-gh-1702

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1738' // https://github.com/neoforged/NeoForge/pull/1738
        url 'https://prmaven.neoforged.net/NeoForge/pr1738'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1738.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1738
cd NeoForge-pr1738
curl -L https://prmaven.neoforged.net/NeoForge/pr1738/net/neoforged/neoforge/21.4.5-beta-pr-1738-gh-1702/mdk-pr1738.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[embeddedt]

O(n) List.contains performance will almost certainly become a problem as soon as there are enough forceloaded chunks.