Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Datagen in LootTables does not reflect the actual super for LootTableProvider #196

Closed
IanOlds opened this issue Nov 13, 2024 · 0 comments · Fixed by #178
Closed
Labels
incorrect Fixes incorrect information.

Comments

@IanOlds
Copy link

IanOlds commented Nov 13, 2024

https://docs.neoforged.net/docs/resources/server/loottables/#blocklootsubprovider

All the supers shown for the lootTableProvider to be pasted in to implement a loot, block or entity subprovider only provide 3 arguments. The super actually takes in 4 and needs the lookupProvider from the event.

This is not clear in the docs and should be clarified to not cause confusion since the variable for the lookup is named registries which implies a loot, block, or entity registry, not the event lookup.

Image

@ChampionAsh5357 ChampionAsh5357 mentioned this issue Nov 13, 2024
20 tasks
@ChampionAsh5357 ChampionAsh5357 added the incorrect Fixes incorrect information. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incorrect Fixes incorrect information.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants