Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4156: Improves handling of empty or blank input for openai procedures #4228

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

vga91
Copy link
Contributor

@vga91 vga91 commented Nov 15, 2024

Fixes #4156

Added input validation to prevent unnecessary API calls toOpenAI when the input is empty or null.
Introduced a boolean flag to allow configuration of the behaviour:

  • If set to true, an exception is raised when an empty (or blank) input is encountered.
  • If false, the API call is silently skipped.

This change improves efficiency by streamlining the process and giving flexibility in handling empty input.

@RobertoSannino RobertoSannino merged commit d6b31c3 into dev Dec 6, 2024
5 checks passed
@RobertoSannino RobertoSannino deleted the issue-4156 branch December 6, 2024 14:46
vga91 added a commit that referenced this pull request Dec 10, 2024
…cedures (#4228)

* Fixes #4156: Improves handling of empty or blank input for openai procedures

* fix tests

* changed boolean conditions
vga91 added a commit that referenced this pull request Dec 10, 2024
…cedures (#4228)

* Fixes #4156: Improves handling of empty or blank input for openai procedures

* fix tests

* changed boolean conditions
vga91 added a commit that referenced this pull request Dec 10, 2024
…cedures (#4228) (#4296)

* Fixes #4156: Improves handling of empty or blank input for openai procedures

* fix tests

* changed boolean conditions
vga91 added a commit that referenced this pull request Dec 18, 2024
…nai procedures (#4228)

* Fixes #4156: Improves handling of empty or blank input for openai procedures

* fix tests

* changed boolean conditions
vga91 added a commit that referenced this pull request Dec 18, 2024
…nai procedures (#4228)

* Fixes #4156: Improves handling of empty or blank input for openai procedures

* fix tests

* changed boolean conditions
vga91 added a commit that referenced this pull request Dec 18, 2024
…nai procedures (#4228) (#4316)

* [NOID] Fixes #4156: Improves handling of empty or blank input for openai procedures (#4228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants