Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Async to async method's name #3206

Merged
merged 2 commits into from
May 2, 2024
Merged

Add Async to async method's name #3206

merged 2 commits into from
May 2, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Apr 30, 2024

Related to #3202 (comment)

@shargon shargon requested review from cschuchardt88 and Jim8y April 30, 2024 08:20
@cschuchardt88
Copy link
Member

You can change your .editorconfig and add warning for the not having async appended and use this setting in Visual Studio to automatically change for all files.

image

image

@cschuchardt88
Copy link
Member

@shargon you can close this i fixed everything for naming and coding styles

See

@shargon shargon merged commit 429a081 into master May 2, 2024
6 checks passed
@shargon shargon deleted the core-add-async branch May 2, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@Jim8y Jim8y Awaiting requested review from Jim8y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shargon @cschuchardt88 @vncoelho