Neo v3.6.2 plan

[roman-khimov]

Summary or problem description
We have a number of known issues that need to be addressed before rolling 3.6 into mainnet (and to have properly functioning testnet). #2910 only has a part of the problem and we need some place to track all the other ones.
3.6 is running on the mainnet, but it has a number of issues that better be fixed soon.

Do you have any solution you want to propose?
We need a 3.6.1 and I'd say we need it this week. master currently contains additional changes from #2905, but we need to concentrate on stabilizing the set we have in 3.6.0, so the proposal is to merge the respective PRs into master (as they're now), then branch off of 4e9314d (and corresponding v3.6.0 commits elsewhere, like in modules) and cherry-pick required changes there.

Modules 3.6.1
Since neo-project/neo-modules#829 has affected users seriously, neo-modules 3.6.1 were released without corresponding core/cli releases, this version has fixed:

• Fix invoke signer neo-modules#821
• Add hardfork settings to getversion RPC call neo-modules#822 (wasn't intended to, but this one is included)
• Transaction Attribute Type Conflict results in crash in RpcClient neo-modules#829

v3.6.2
Given the modules situtation, the next release for every component should be 3.6.2.

Mandatory issues to fix:

• Contract Permission exception still affecting neo #2890 #2899
• conflict attribute stops the network #2907
• Rpc Server: WitnessRules potential DDOS #2950
• Transaction Attribute Type Conflict results in crash in RpcClient neo-modules#829 (fixed in modules 3.6.1)

Discussion:

• checklist of 3.6.0 PRs that will cause FORK #2910 (irrelevant after the mainnet upgrade)
• Voting to NULL ("unvoting") in NEO doesn't clear LastGasPerVote #2894 (not worth the delay and resync after the mainnet upgrade)

Related PRs:

• Validate serialization during Contract deploy and Update #2948
• fix contract trust FromStackItem ContractPermissionDescriptor.Create(StackItem item) #2901
• Improved scheme for Conflicts attribute storing and pricing #2913
• Set attribute fee #2916
• Add MaxNestedItems to WitnessCondition.FromJson #2951
• DBFTPlugin: adapt new Conflicts attribute storage scheme neo-modules#828
• Reduce json max depth default value #2912 and MaxParamsDepth and MaxRequestBodySize in RpcServer neo-modules#827
• Fix RpcClient TxConflict neo-modules#830 (released with modules 3.6.1)
• Update CalculateNetworkFee #2920
• add cancel command for conflict attribute neo-node#903
• RpcServer, RpcClient: strip HF_ prefix from getversion response neo-modules#838
• Enhance the limits neo-vm#514
• Ensure nef file fit in vm #2939

Suggestions/opinions/alternatives are welcome. I'll add some comments below to keep these lists clean.

[roman-khimov]

The "mandatory" list above is as conservative as it could be, following the "have resynchronization fun" paradigm. It's not final and my proposal is to extend it with:

• hardfork dependency for things that change behavior, that is NeoToken.UnclaimedGAS and NeoToken.GetAccountState from Optimize vote reward data #2841
• a simple storage scheme fix for Voting to NULL ("unvoting") in NEO doesn't clear LastGasPerVote #2894 since we have to resynchronize anyway (it's not critical, but it's very very simple at the same time)

[steven1227]

Fully agree on this one.

[roman-khimov]

Mainnet is at 3.6 now, which makes 3.6-specific part of #2910 irrelevant (not the underlying problem, of course), removed from the list.

[roman-khimov]

Retracting #2894 (unsafe wrt state change, not worth any delay). Let's at least push the main set out the door.

[roman-khimov]

Added neo-project/neo-modules#829/neo-project/neo-modules#830

[roman-khimov]

Updated in accordance with https://github.com/neo-project/neo-modules/releases/tag/v3.6.1

[shargon]

Added #2920

[superboyiii]

neo-project/neo-node#903, Please

[AnnaShaleva]

Let's consider the neo-project/neo-modules#838, please. It's related to neo-project/neo-modules#822.

[roman-khimov]

Added neo-project/neo-vm#514, can be replaced if doesn't fit for some reason, but the issue needs to be fixed.

[AnnaShaleva]

#2939 should also be added.

[roman-khimov]

#2939 should also be added.

Sure.

[shargon]

#2942 should be added in 3.6 2

[roman-khimov]

But why? We can deliver the set of changes from the list in a patch release and then deal with these extensions. The idea was to have a quick release fixing the most critical problems. Otherwise I'd say 3.6.2 is in trouble, we're risking destabilizing it with too many changes.

[shargon]

But why? We can deliver the set of changes from the list in a patch release and then deal with these extensions. The idea was to have a quick release fixing the most critical problems. Otherwise I'd say 3.6.2 is in trouble, we're risking destabilizing it with too many changes.

We currently merged some changes that affects hardforks with native contracts, but agree that currently are not used, so we can focus on this, and prioritize it for the next release.

[shargon]

@superboyiii Ready to fly

[Jim8y]

Propose to close this issue since version 3.6.2 is released.

[shargon]

Released 3.6.2

[roman-khimov]

Huh. I'd do it after I see something in https://github.com/neo-project/neo-node/releases, but OK and it'll be easier with #2944.