Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the cost of registering as a candidate #2234

Closed
erikzhang opened this issue Jan 15, 2021 · 19 comments · Fixed by #2252
Closed

Increase the cost of registering as a candidate #2234

erikzhang opened this issue Jan 15, 2021 · 19 comments · Fixed by #2252
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@erikzhang
Copy link
Member

The idea is from #2203 (comment)

We should increase the cost of registering as a candidate to prevent attacks.

Question: What is the appropriate price for RegisterCandidate?

@erikzhang erikzhang added the Discussion Initial issue state - proposed but not yet accepted label Jan 15, 2021
@lock9
Copy link
Contributor

lock9 commented Jan 15, 2021

Hi Erik, I have a few questions:

  • If they lose the election, their money is gone, right?
  • Is the APY is GAS based?
  • What happens to the tokens if they are not elected? Is it burned?
  • Is the registration permanent? Once registered, I can always get votes and never be elected, or is there a limit for a candidate to get the votes?

My only concern is that it may be too risky for 'regular people' to participate. I mean, if there is a chance to lose $10.000, I would probably not have the courage to register as a candidate. But if that means that I will be a candidate 'forever', then it may be a good thing to increase the price.

Question: What is the appropriate price for RegisterCandidate?

I suggest that we do something based on the available supply, like 0.0001% of the circulating GAS/NEO

@erikzhang
Copy link
Member Author

If they lose the election, their money is gone, right?

Yes.

Is the APY is GAS based?

Yes.

What happens to the tokens if they are not elected? Is it burned?

Yes.

Is the registration permanent?

Currently, yes. But maybe we can add an expiration date.

@lock9
Copy link
Contributor

lock9 commented Jan 15, 2021

Hmm, maybe adding an expiration date will add too much complexity. What happens if it expires while they are elected?

Do you want to make it 'fiat pegged' prices, like U$1.000, or are you looking for something based on NEO/GAS? The second one will need to adjustable since the prices will likely go up.

@ioannistsil
Copy link

Hmm, maybe adding an expiration date will add too much complexity. What happens if it expires while they are elected?

Do you want to make it 'fiat pegged' prices, like U$1.000, or are you looking for something based on NEO/GAS? The second one will need to adjustable since the prices will likely go up.

i believe NEO /GAS based should be the best option to go!

@ioannistsil
Copy link

I suggest that we do something based on the available supply, like 0.0001% of the circulating GAS/NEO

i like your idea to use available supply as index , this could work also like halving mechanism

@shargon
Copy link
Member

shargon commented Jan 15, 2021

My worry is:

I pay for be a candidate, but I am waiting for two mothns without luck, one day I am candidate, but maybe I had shutdowned my computer and leaved the crypto world, we should need an ACK before be a valid one.

@Tommo-L
Copy link
Contributor

Tommo-L commented Jan 15, 2021

we should need an ACK before be a valid one.

We thought this before. One way is that candidate can send an ack transaction before it becomes a validator(Validator need one epoch to take effect). Another way we can take advantage of committee's epoch to switch up to 1/3 nodes at a time, while checking the block production within epoch.

@erikzhang
Copy link
Member Author

erikzhang commented Jan 15, 2021

What about 1000 GAS for register as a candidate? @neo-project/ngd-shanghai What do you think?

@shargon
Copy link
Member

shargon commented Jan 15, 2021

What about 1000 GAS for register as a candidate?

it's good for me

@i359
Copy link

i359 commented Jan 15, 2021

It is suggested to set the parameter as 1000gas tentatively, which can be adjusted by voting in the future.

@ioannistsil
Copy link

What about 1000 GAS for register as a candidate? @neo-project/ngd-shanghai What do you think?

I suggest to do a formula based of circulate supply since gas supply is unlimited in few years 1000 gas could be very cheap so a fixed percentage of supply could solve the problem for ever.

@ProDog
Copy link
Contributor

ProDog commented Jan 18, 2021

1000 might be too high, it may affects the level of engagement. I think we should prevent attacks, but remain attractive for many users. In Neo2's experience, many users can't easily deploy contract because it's too expensive.-O-

@erikzhang
Copy link
Member Author

In Neo2's experience, many users can't easily deploy contract because it's too expensive.

This proposal is for registerCandidate, not for deployment.

@Tommo-L
Copy link
Contributor

Tommo-L commented Jan 18, 2021

It's good for me, and it'll be better, if we can set a parameter.

It is suggested to set the parameter as 1000gas tentatively, which can be adjusted by voting in the future.

@longfeiWan9
Copy link
Member

@erikzhang may I bring up two questions:

  1. Could we code this as an adjustable params so that committee will be able to adjust it in the future according to the reward and price of GAS ? Initial 1000 GAS is good.
  2. Should we think about punishment as well ? To prevent committees or CN act maliciously or off line irresponsibly which we have experienced for Neo2 mainnet.

@ioannistsil
Copy link

@wanglongfei88 i agree with, The Carrot and the Stick !

@erikzhang
Copy link
Member Author

Could we code this as an adjustable params so that committee will be able to adjust it in the future according to the reward and price of GAS ?

Sure.

Should we think about punishment as well ?

Any idea?

@ioannistsil
Copy link

Any idea?
well my idea is to have a 10-20% of their stake a insurance against malicious actions if they do something illegal this insurance percentage will be burned. or be distributed among other legal voters or commites.

@lock9
Copy link
Contributor

lock9 commented Jan 18, 2021

What is considered a malicious action? Can we list all cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants