UT seems it changed

neo-project · Nov 22, 2024 · 0569d1a · 0569d1a
1 parent 862fa78
commit 0569d1a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -57,7 +57,6 @@ indent_size = 2
 [*.{cs,vb}]
 # Use block-scoped namespace
 csharp_style_namespace_declarations = block_scoped:error
-dotnet_diagnostic.CA2265.severity = none
 dotnet_diagnostic.IDE0160.severity = error
 dotnet_diagnostic.IDE0161.severity = error
 

diff --git a/src/Neo.VM/ScriptBuilder.cs b/src/Neo.VM/ScriptBuilder.cs
@@ -126,9 +126,8 @@ public ScriptBuilder EmitPush(bool value)
         /// <returns>A reference to this instance after the emit operation has completed.</returns>
         public ScriptBuilder EmitPush(ReadOnlySpan<byte> data)
         {
-            if (data == null)
+            if (data == null) // IsEmpty also throw null
                 throw new ArgumentNullException(nameof(data));
-
             if (data.Length < 0x100)
             {
                 Emit(OpCode.PUSHDATA1);

diff --git a/tests/Neo.VM.Tests/UT_ScriptBuilder.cs b/tests/Neo.VM.Tests/UT_ScriptBuilder.cs
@@ -42,6 +42,23 @@ public void TestEmit()
             }
         }
 
+        [TestMethod]
+        public void TestNullAndEmpty()
+        {
+            using (ScriptBuilder script = new())
+            {
+                Assert.ThrowsException<ArgumentNullException>(() =>
+                {
+                    ReadOnlySpan<byte> span = null;
+                    script.EmitPush(span);
+                });
+
+                ReadOnlySpan<byte> span = [];
+                script.EmitPush(span);
+                CollectionAssert.AreEqual(new byte[] { (byte)OpCode.PUSHDATA1, 0 }, script.ToArray());
+            }
+        }
+
         [TestMethod]
         public void TestBigInteger()
         {