A question of ContractParameter.FromJson(ByteString)

[ProDog]

Now we get ByteString type of result's stack when invoke contract, it's StackItemType.
In RpcClient, we convert stack use:

neo-modules/src/RpcClient/Models/RpcInvokeResult.cs

Line 47 in dcd946a

invokeScriptResult.Stack = ((JArray)json["stack"]).Select(p => ContractParameter.FromJson(p)).ToArray();

but in ContractParameter.FromJson(JObject json) is no ByteString type, it's should be ContractParameterType:
https://github.com/neo-project/neo/blob/b47157669cabc9c4f0f4ff56cf4fe2a82905bcfe/src/neo/SmartContract/ContractParameter.cs#L58

Can we support StackItemType convert to ContractParameterType or StackItem.FromJson(JObject json) etc ?

[shargon]

Could you make a unit test for reproduce the issue? I don't understand very well the problem

[devhawk]

@shargon #300

[ProDog]

@shargon I have updated unit test for this issue, please have a look at it #301 .

[Qiao-Jin]

This issue is caused by reading json of StackItem as ContractParameter, and I doubt whether this is correct ... And it seems that StackItemType & ContractParameterType are not accordance in more than one types:

ContractParameterType.ByteArray
ContractParameterType.String
ContractParameterType.Hash160
ContractParameterType.Hash256
ContractParameterType.PublicKey
ContractParameterType.Signature
ContractParameterType.Void

&

StackItemType.Pointer
StackItemType.ByteString
StackItemType.Buffer
StackItemType.Struct

[Tommo-L]

Both RpcServer and RpcClient use StackItemType?

[ProDog]

Only RpcClient need to deal with the invokescript's result.