Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RpcNep5Tracker] Using contract id instead of contract scriptHash. #195

Open
nicolegys opened this issue Mar 18, 2020 · 3 comments · Fixed by #196
Open

[RpcNep5Tracker] Using contract id instead of contract scriptHash. #195

nicolegys opened this issue Mar 18, 2020 · 3 comments · Fixed by #196

Comments

@nicolegys
Copy link
Contributor

Now the plugin uses contract scriptHash to creat a key in storage.
image
Shall we use contract id instead? Since now we support migrating/destroying a contract, the scriptHash could be changed/deleted.
Maybe we also need to handle notifications other than transfer, to handle the migration/destroy scenes.

@shargon
Copy link
Member

shargon commented Mar 18, 2020

Yes, we should do it

@ProDog
Copy link
Contributor

ProDog commented Jul 8, 2020

This can be reopened? the scriptHash could not be changed if contract migrated. @Tommo-L

@Tommo-L
Copy link
Contributor

Tommo-L commented Jul 8, 2020

Yes, plz reopen it.

@ProDog ProDog reopened this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants