Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issue template #295

Closed
lock9 opened this issue Nov 6, 2023 · 13 comments
Closed

Create issue template #295

lock9 opened this issue Nov 6, 2023 · 13 comments

Comments

@lock9
Copy link
Contributor

lock9 commented Nov 6, 2023

Problem:
We don't have an issue template in this repository. Issue templates make bug reporting/creating new tasks more efficient.

Proposed Solution:
Create an issue template similar to what we have in other Neo repositories.

@lock9 lock9 changed the title Create issue templates Create issue template Nov 6, 2023
@cschuchardt88
Copy link
Member

Yes if someone could add this that would be nice. Labels would be nice too and having access to add them to issues is nice too.

@cschuchardt88
Copy link
Member

@Liaojinghui any word on this? No, rush.

@Jim8y
Copy link
Contributor

Jim8y commented Nov 17, 2023

@Liaojinghui any word on this? No, rush.

I can not create pr for this repo, that will make me not able to merge it.


name: Issue Template
about: Template for creating issues in neo-project/neo-express repository
title: '[Issue Type]: Brief Description'
labels: ''
assignees: ''


Issue Type

Description

Reproduction Steps

Expected Behavior

Actual Behavior

Version Information

  • Neo-Express Version:
  • NEO Blockchain Version:
  • Operating System:

Additional Context

@cschuchardt88
Copy link
Member

@Liaojinghui ill do it

@cschuchardt88
Copy link
Member

cschuchardt88 commented Nov 17, 2023

@Liaojinghui @lock9 this can be closed now

@Jim8y Jim8y closed this as completed Nov 17, 2023
@lock9
Copy link
Contributor Author

lock9 commented Nov 17, 2023

I didn't have a chance to check the template. I saw that it was just copied from some other place... there was no analysis - literally.

@Jim8y
Copy link
Contributor

Jim8y commented Nov 17, 2023

I didn't have a chance to check the template. I saw that it was just copied from some other place... there was no analysis - literally.

@lock9 We can create another pr to update the template, since it is not code logic related.

@lock9
Copy link
Contributor Author

lock9 commented Nov 17, 2023

I know, but now it's twice the work, you know? We would have better results if we had planned it. The current template doesn't make much sense to us :(

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

This is not applicable :(

I agree that we can create another PR. Let's fix it with neo-project/neo#2975 instead.

@Jim8y
Copy link
Contributor

Jim8y commented Nov 17, 2023

I agree that we can create another PR. Let's fix it with neo-project/neo#2975 instead.

My bad, too many issues in the neo project, I prefer to merge as soon as possible if there is no obvious issues. Next time, i will wait.

@lock9
Copy link
Contributor Author

lock9 commented Nov 17, 2023

Something to consider for the development process. I can't complain. There aren't rules about merging.

@Jim8y
Copy link
Contributor

Jim8y commented Nov 17, 2023

Something to consider for the development process. I can't complain. There aren't rules about merging.

I prefer an optimistic way to work on non-critical issues, then fallback when problems are discovered. Expecially when we have tons of issues to fix. The same reason that i prefer to close ancient issues aggresively. But will wait longer in the future.

BTW, the reason that i perfer to do it this way is because if we want to make neo core a solid project, i think another 20,000-50,000 lines of code will be added, if we do not work in an optimistic way for non-critical issues, it takes forever. That thought influenced me maintaning this repo.

@lock9
Copy link
Contributor Author

lock9 commented Nov 17, 2023

I understand. I agree with you: we need to reduce the development and release cycle as much as possible. However, in some cases, this may backfire and cause more issues that will take longer to resolve.
This wasn't the case - it has a very low impact. However, we should have some rules to avoid that in the future. Since the team works on different timezones, it would be nice if we had at least 12 hours for the PR to be merged. Maybe 12 hours or 2 approvals?
I think this will make the process fast enough.

In this case, the PR, approval and merge happened in less than one hour. I was awake but didn't have time to do anything :(

@cschuchardt88
Copy link
Member

cschuchardt88 commented Nov 17, 2023

I know, but now it's twice the work, you know? We would have better results if we had planned it. The current template doesn't make much sense to us :(

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

This is not applicable :(

I agree that we can create another PR. Let's fix it with neo-project/neo#2975 instead.

how is this bad. It's just an example. Im sure users that are using this program are not brain dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants