Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudocode Comments #2

Open
jjacobson95 opened this issue Aug 1, 2021 · 0 comments
Open

Pseudocode Comments #2

jjacobson95 opened this issue Aug 1, 2021 · 0 comments

Comments

@jjacobson95
Copy link

Looking like some pseudo-pseudocode to me. Good work overall, I think you’ve got a good understanding of the problem. I like that you just put it all in a function. Great idea for future use. The order of the filters within this function make sense and sends files to the appropriate bins. I’m not certain on this, but is it best to send read + index +index to each bin or should you just send the read +index (or even just read)? A couple more things to specify – how are you storing the 4-line records from each file? How are you generating the filenames? And it is unaddressed how you match the indexes (index 1 == reverse compliment of index 2). A bit more work to do, but good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant