Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-w eats CPU #2

Open
AeliusSaionji opened this issue May 4, 2013 · 4 comments
Open

-w eats CPU #2

AeliusSaionji opened this issue May 4, 2013 · 4 comments
Assignees
Labels

Comments

@AeliusSaionji
Copy link

The -w chews on a rather disturbing amount of CPU (12% of 4.43GHz).

Normally there isn't much of a wait but I had something wrong with explorer and the toasts weren't running consistently, which is how I noticed.

@nels-o
Copy link
Owner

nels-o commented Jul 6, 2013

Ah. Yeah this is one of my less brilliant moves. Since there is an indeterminate amount of time for the notification to be active I was just spinning in a while loop waiting for the toast notification to return. I'll do some experiments with turning that into a polling loop with a thread sleep and see if that gets things set right.

@ghost ghost assigned nels-o Jul 7, 2013
@nels-o
Copy link
Owner

nels-o commented Jul 7, 2013

I'm going to hesitantly close this as fixed, pending more issues. Instead of spinning, it should now use a polling loop and Thread.Sleep to be a little more frugal with system resources.

@nels-o nels-o closed this as completed Jul 7, 2013
@AeliusSaionji
Copy link
Author

There seems to be a trick in getting this to work with 8.1- on my other two computers I had to play around with it for a bit to get it working.

I'm having strange behavior on my newest laptop (doesn't work, gives an error when using -w with -m, no error but waits indefinitely with -t, etc). I can't get it to work, but....

This gives me a chance to test out your fix!
On this laptop, i7-4500U clocked at 1.80GHz, toast is using 25% of the CPU. :(

@nels-o
Copy link
Owner

nels-o commented Dec 29, 2013

Time to reopen this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants