Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Symfony Yaml PHP constants support integration #829

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Add Symfony Yaml PHP constants support integration #829

merged 1 commit into from
Oct 31, 2017

Conversation

soullivaneuh
Copy link
Contributor

Closes #827

@soullivaneuh soullivaneuh mentioned this pull request Oct 31, 2017
Merged
@soullivaneuh
Copy link
Contributor Author

I have to confess I don't understand why the tests are failing.

Could you please help me?

@theofidry
Copy link
Member

Because the call is no longer parse($fileContent) here but it gets the constant as well depending of the YAML parser version

@soullivaneuh
Copy link
Contributor Author

Ok thanks, I'll try to simplify the call.

@soullivaneuh
Copy link
Contributor Author

Well, I can't because the yaml component does not accept parsing flags under SF 2.7.

I'll add conditional code on the tests.

@soullivaneuh soullivaneuh force-pushed the yaml-php-constant-master branch from c11a276 to 229fac6 Compare October 31, 2017 10:56
@soullivaneuh
Copy link
Contributor Author

@theofidry I tried this: https://github.com/nelmio/alice/pull/829/files#diff-1bb89596d4482090faac6e8ff7ed270cR145

But this does not seem to change anything. 😕

@theofidry
Copy link
Member

https://github.com/nelmio/alice/pull/829/files#diff-1bb89596d4482090faac6e8ff7ed270cR158 should be updated to Argument::cetera() I think

@soullivaneuh
Add Symfony Yaml PHP constants support integration
89ae97c 
Ref: http://symfony.com/blog/new-in-symfony-3-2-php-constants-in-yaml-files

This addition is backward compatible as the Yaml flag will be used only
if it is defined.
@soullivaneuh soullivaneuh force-pushed the yaml-php-constant-master branch from 229fac6 to 89ae97c Compare October 31, 2017 11:13
@soullivaneuh
Copy link
Contributor Author

Aaaaannnnd all is fixed! \o/

@theofidry
Copy link
Member

Thanks very much :)

@theofidry theofidry merged commit bd42498 into nelmio:master Oct 31, 2017
@soullivaneuh soullivaneuh deleted the yaml-php-constant-master branch October 31, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soullivaneuh @theofidry