Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony Yaml PHP constants support integration (2.x) #828

Merged
merged 2 commits into from
Oct 31, 2017

Conversation

soullivaneuh
Copy link
Contributor

Closes #827

@theofidry How do you want to backport this to master? Will you do a manual merge? Would you like me to cherry-pick this feature on an another PR?

Ref: http://symfony.com/blog/new-in-symfony-3-2-php-constants-in-yaml-files

This addition is backward compatible as the Yaml flag will be used only
if it is defined.
@soullivaneuh
Copy link
Contributor Author

According to your requirement:

I don't have any extra steps to do than review, merge and release

I'll cherry-pick it on master right now. 👍

@soullivaneuh soullivaneuh changed the title Add Symfony Yaml PHP constants support integration Add Symfony Yaml PHP constants support integration (2.x) Oct 31, 2017
@soullivaneuh
Copy link
Contributor Author

See #829 for master.

@theofidry
Copy link
Member

👍 I'll merge both of them at the same time, thanks :)

@theofidry theofidry merged commit 41fc89e into nelmio:2.x Oct 31, 2017
@soullivaneuh soullivaneuh deleted the yaml-php-constant branch October 31, 2017 12:31
@soullivaneuh
Copy link
Contributor Author

Thanks for the merge. 👍

Can you please make a new release for that?

@theofidry
Copy link
Member

yep, done

@soullivaneuh
Copy link
Contributor Author

Thanks, it works like a charm! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants