Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine string token followed by reference #783

Merged
merged 3 commits into from
Sep 14, 2017

Conversation

simshaun
Copy link
Contributor

@simshaun simshaun commented Sep 7, 2017

Closes #780

@theofidry
Copy link
Member

👌

Do you mind to add a small integration test? You'll need to add it in both LexerIntegrationTest and ParserIntegrationTest as both need to be synchronized

@theofidry theofidry changed the title Combine string token followed by reference to fix #780 Combine string token followed by reference Sep 7, 2017
@simshaun
Copy link
Contributor Author

simshaun commented Sep 8, 2017

Added integration tests. I wasn't exactly sure what to name the scenarios or where to place them in the data provider though.

@simshaun
Copy link
Contributor Author

Not sure why the lexer test is failing in the Symfony run on Travis.

@theofidry
Copy link
Member

theofidry commented Sep 11, 2017

This indeed looks very weird, can you reproduce it locally (try make ts)? I'll try to check it out during the week

@simshaun
Copy link
Contributor Author

simshaun commented Sep 13, 2017

Yea I just got it to error locally with make ts. I'm trying to figure out why the Symfony test lexes differently, but I'm stumped at the moment.

Edit: Think I got it. The new lexer needed to be setup in the lexer chain in the Symfony DIC.

@theofidry theofidry merged commit 1051dfb into nelmio:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants