Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#645 fixed array function arguments #775

Merged
merged 2 commits into from
Aug 1, 2017

Conversation

marinoska
Copy link
Contributor

fixes parsing arrays as a function argument,
example:
the
<randomElement(['facebook','instagram','vkontakte'], 'test', ['lalala'])>
should be processed into three tokens/arguments:
['facebook','instagram','vkontakte']
'test'
['lalala']

@theofidry
Copy link
Member

Thanks very much! Do you mind adding a test to LexerIntegrationTest and ParserIntegrationTest as well?

@marinoska
Copy link
Contributor Author

ah... In fact I missed it, I'll add them later then :)

@theofidry theofidry merged commit 28facec into nelmio:master Aug 1, 2017
@theofidry
Copy link
Member

👌 🎉

@marinoska marinoska deleted the 645-fix-array-arguments branch August 2, 2017 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants