Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow search to be separate for each root #82

Closed
catthehacker opened this issue Sep 3, 2020 · 4 comments
Closed

Allow search to be separate for each root #82

catthehacker opened this issue Sep 3, 2020 · 4 comments

Comments

@catthehacker
Copy link

e.g.: root called PolArt domain.tld/PolArt/search would show results only for that root

@nektro
Copy link
Owner

nektro commented Sep 7, 2020

would this make it impossible to have a file named search in PolArt and any other roots?

@catthehacker
Copy link
Author

Yes, but I assume the point of roots is that they are separated and no one can know about just from the application. Going to search I can find all my roots which kind of defeats the purpose of roots. One option would be to make search as GET domain.tld/PolArt/?action=search

@nektro
Copy link
Owner

nektro commented Sep 7, 2020

It only shows the roots you can "see", that being public roots and any private ones you've been given view access to. This behavior could change or put behind a flag.

@catthehacker
Copy link
Author

would this make it impossible to have a file named search in PolArt and any other roots?

Doesn't it make impossible to have root called search?

domain.tld/PolArt/?action=search

Better one, domain.tld/search/root_name that could be enabled by flag/config to scope search to specific roots and global search is unavailable/only for admin/s/discord group/etc.

@nektro nektro closed this as completed in 00684ad Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants