From 1a7e21dd610976c49884eecc9426328d215f7d6a Mon Sep 17 00:00:00 2001 From: Vinoth Kumar Chandrasekar Date: Fri, 29 Mar 2024 14:39:34 -0700 Subject: [PATCH 1/2] Trigger From 846d7f774c0195ce1efc7cd862b267d4b7d44a54 Mon Sep 17 00:00:00 2001 From: Vinoth Kumar Chandrasekar Date: Tue, 16 Apr 2024 16:39:04 -0700 Subject: [PATCH 2/2] Fix Policy formatting --- README.md | 4 ++++ __tests__/helpers/target.ts | 6 +++--- package-lock.json | 4 ++-- package.json | 2 +- src/aws/target.ts | 2 +- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 699e30a..a4bac3f 100644 --- a/README.md +++ b/README.md @@ -151,6 +151,9 @@ N/A - [Clay Danford](mailto:crd013@gmail.com) - [Dawid Boissé](mailto:dawid.boisse@gmail.com) + +## Contributors + - [Vinoth Kumar Chandrasekar](vinothchandra87@gmail.com) ## Conduct / Contributing / License @@ -159,6 +162,7 @@ N/A - All contributions must follow our code of conduct. See [CONDUCT.md](https://github.com/neiman-marcus/serverless-provisioned-concurrency-autoscaling/tree/master/CONDUCT.md). - This project is licensed under the Apache 2.0 license. See [LICENSE](https://github.com/neiman-marcus/serverless-provisioned-concurrency-autoscaling/tree/master/LICENSE). + ## Acknowledgments - [serverless-dynamodb-autoscaling](https://github.com/sbstjn/serverless-dynamodb-autoscaling) - Original plugin this module is based on. diff --git a/__tests__/helpers/target.ts b/__tests__/helpers/target.ts index ee95859..0d93d39 100644 --- a/__tests__/helpers/target.ts +++ b/__tests__/helpers/target.ts @@ -11,7 +11,7 @@ export const expectedTarget = { ServiceNamespace: 'lambda', RoleARN: { 'Fn::Sub': - 'arn:aws:iam::#{AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency', + 'arn:aws:iam::${AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency', }, }, Type: 'AWS::ApplicationAutoScaling::ScalableTarget', @@ -29,7 +29,7 @@ export const expectedTargetWithSingleScheduledAction = { ServiceNamespace: 'lambda', RoleARN: { 'Fn::Sub': - 'arn:aws:iam::#{AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency', + 'arn:aws:iam::${AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency', }, ScheduledActions: [ { @@ -56,7 +56,7 @@ export const expectedTargetWithScheduledActions = { ServiceNamespace: 'lambda', RoleARN: { 'Fn::Sub': - 'arn:aws:iam::#{AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency', + 'arn:aws:iam::${AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency', }, ScheduledActions: [ { diff --git a/package-lock.json b/package-lock.json index 2203dda..803ef63 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "serverless-provisioned-concurrency-autoscaling", - "version": "2.0.0", + "version": "2.0.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "serverless-provisioned-concurrency-autoscaling", - "version": "2.0.0", + "version": "2.0.1", "license": "Apache-2.0", "devDependencies": { "@serverless/utils": "^6.15.0", diff --git a/package.json b/package.json index 3f273d9..e2caaf5 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "serverless-provisioned-concurrency-autoscaling", - "version": "2.0.0", + "version": "2.0.1", "description": "Serverless Plugin for AWS Lambdas Provisioned Concurrency Auto Scaling Configuration.", "main": "./lib/index.js", "files": [ diff --git a/src/aws/target.ts b/src/aws/target.ts index d0c5a32..46d3591 100644 --- a/src/aws/target.ts +++ b/src/aws/target.ts @@ -49,7 +49,7 @@ export default class Target { ServiceNamespace: 'lambda', RoleARN: { 'Fn::Sub': - 'arn:aws:iam::#{AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency', + 'arn:aws:iam::${AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency', }, ScheduledActions: this.data.scheduledActions ? this.getSchedulesActions()