Vocal crashes after start on openSUSE

[sdicke]

When I run a build from current master branch cloned shortly and I run the application (installed in /usr/local) the GUI is shown and then it crashes. I already imported some feeds with the latest release version build provided by openSUSE. This problem is reproducible.

Please share as many of the following details as possible:

• Linux distrubution: openSUSE
• OS version: Tumbleweed
• Desktop environment: KDE

• [ x] I'm using the latest version from git that I've manually compiled

Stacktrace:

#0 0x00007ffff7bf40d4 in g_date_time_to_unix () at /usr/lib64/libglib-2.0.so.0
#1 0x000000000043ee2b in vocal_library_write_episode_to_database ()
#2 0x0000000000437840 in _lambda38 ()
#3 0x0000000000437a0b in ___lambda38__gthread_func ()
#4 0x00007ffff7c3518e in () at /usr/lib64/libglib-2.0.so.0
#5 0x00007ffff18c0efa in start_thread () at /lib64/libpthread.so.0
#6 0x00007ffff1bb93bf in clone () at /lib64/libc.so.6

Application output (with gdb additions):

Starting program: /usr/local/bin/com.github.needleandthread.vocal
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
[New Thread 0x7fffef852700 (LWP 11012)]
[New Thread 0x7fffef051700 (LWP 11013)]
[New Thread 0x7fffee7dc700 (LWP 11014)]
[New Thread 0x7fffed00a700 (LWP 11015)]
[New Thread 0x7fffec809700 (LWP 11016)]
[New Thread 0x7fffd7fff700 (LWP 11017)]
[New Thread 0x7fffd77fe700 (LWP 11018)]
[INFO 20:26:00.976937] Application.vala:156: Vocal version: 2.4.2
[INFO 20:26:00.976977] Application.vala:158: Kernel version: 5.5.4-1-default
[INFO 20:26:00.980467] Controller.vala:75: Initializing the controller.
[INFO 20:26:00.980492] Controller.vala:79: Initializing the player from GStreamer.
[INFO 20:26:00.992260] Controller.vala:84: Initializing the iTunes store provider.
[INFO 20:26:00.992564] Controller.vala:88: Establishing a connection to your podcast library.
[INFO 20:26:00.993666] Library.vala:126: Performing database update check. Current version: 1
[INFO 20:26:00.993829] Controller.vala:93: Initiating the gpodder API
[INFO 20:26:00.993857] Controller.vala:98: Initializing the main window.
[INFO 20:26:00.994509] MainWindow.vala:201: Loading CSS providers.
[INFO 20:26:00.995027] MainWindow.vala:240: Creating video playback widgets.
[INFO 20:26:00.997737] MainWindow.vala:297: Creating notebook.
[INFO 20:26:00.997834] MainWindow.vala:303: Creating podcast view.
[INFO 20:26:01.007582] MainWindow.vala:310: Creating welcome screen.
[INFO 20:26:01.008080] MainWindow.vala:323: Creating new episodes view.
[INFO 20:26:01.008985] MainWindow.vala:337: Creating scrolled containers and album art views.
[INFO 20:26:01.010841] MainWindow.vala:395: Creating directory view.
[New Thread 0x7fffd6f42700 (LWP 11019)]
[INFO 20:26:01.011776] DirectoryView.vala:127: Getting top podcasts asynchronously?.
[INFO 20:26:01.012103] MainWindow.vala:411: Creating toolbar.
[INFO 20:26:01.014906] MainWindow.vala:516: Creating show notes popover.
[INFO 20:26:01.016772] MainWindow.vala:526: Creating downloads popover.
[INFO 20:26:01.017750] MainWindow.vala:534: Creating queue popover.
[INFO 20:26:01.017855] MainWindow.vala:560: Adding notebook to window.
[Detaching after vfork from child process 11020]
[Detaching after vfork from child process 11022]
[INFO 20:26:01.150167] MainWindow.vala:598: Window initialization complete.
[INFO 20:26:01.150219] Controller.vala:107: Initializing MPRIS playback.
[New Thread 0x7fffd5a40700 (LWP 11024)]
[INFO 20:26:01.182802] Controller.vala:144: Initializing notifications.
[INFO 20:26:01.182832] Controller.vala:152: Setting up media keys.
[WARNING 20:26:01.183990] Controller.vala:177: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.SettingsDaemon was not provided by any .service files
[INFO 20:26:01.184014] Controller.vala:180: Setting up keyboard shortcuts.
[INFO 20:26:01.184059] Controller.vala:249: Refilling library.
[INFO 20:26:01.184403] Controller.vala:272: Controller initialization finished. Running post-creation sequence.
[INFO 20:26:01.184424] MainWindow.vala:609: Populating the main podcast view.
[INFO 20:26:01.184439] MainWindow.vala:624: Restoring last played media.
[INFO 20:26:01.184462] MainWindow.vala:685: Creating coverart for each podcast in library.
[INFO 20:26:01.184770] MainWindow.vala:727: Adding coverart to view.
[Detaching after vfork from child process 11025]
[INFO 20:26:01.342891] Controller.vala:651: Checking for updates.
[New Thread 0x7fffd4c65700 (LWP 11027)]
[INFO 20:26:01.343238] Library.vala:463: updating feed https://1337kultur.de/feed/podcast-ogg/
[New Thread 0x7fffbffff700 (LWP 11028)]
[New Thread 0x7fffbf7fe700 (LWP 11029)]
[INFO 20:26:01.518178] DirectoryView.vala:129: Top 100 podcasts loaded.
[Thread 0x7fffd6f42700 (LWP 11019) exited]

Thread 11 "vocal" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffd4c65700 (LWP 11027)]
0x00007ffff7bf40d4 in g_date_time_to_unix () from /usr/lib64/libglib-2.0.so.0

[Hanouta]

It seems like the crash occurs on this line
https://github.com/needle-and-thread/vocal/blob/b41b1a7c778d02b1b5b1a42a06ceb8bcc3ae389f/src/Library.vala#L1395
because episode.datetime_released is null.

The underlying issue seems to be somewhere in here:
https://github.com/needle-and-thread/vocal/blob/b41b1a7c778d02b1b5b1a42a06ceb8bcc3ae389f/src/Objects/Episode.vala#L115-L129
because date_released returns the correct value, while datetime_released is null. I think it's caused by line 119 specifically, it looks like tm.strptime isn't doing anything here, no idea why though.

[Hanouta]

I actually just figured out what the issue is, PR incoming.