define propTypes for compatibility

[mo22]

Hi,

a lot of react-native libraries use ReactNative.Text.propTypes.style or ReactNative.ViewPropTypes to define their own propTypes.

I know that propTypes are deprecated, but right now this causes a lot of "cannot read property style of undefined" errors with third party libraries.

My workaround is to monkey patch the prop types:

import * as ReactNative from 'react-native-web';
{
  const PropTypes = require('prop-types');
  ReactNative.Text.propTypes = { style: PropTypes.any };
  ReactNative.View.propTypes = { style: PropTypes.any };
  ReactNative.Image.propTypes = { style: PropTypes.any };
  ReactNative.ViewPropTypes = { style: PropTypes.any };
}

I wonder if it makes sense to have the propTypes still defined by react-native-web for better user experience or just wait until propTypes are removed from the third party libraries.

Cheers
Mo

[LinusU]

Would you mind sharing which libraries this is? I think that the correct course is to send PRs to them ☺️

[mo22]

I recall that react-native-swipeout was affected, and others also.

It's gonna be quite hard to push the removal of propTypes to those libraries as long as the latest react-native still provides them.

[dested]

I am currently dealing with it with https://github.com/archriss/react-native-snap-carousel

[necolas]

React Native is going to stop exporting prop types so libraries should stop depending on them. I don't plan to add them back to RNfW

[jer-sen]

React Native is going to stop exporting prop types so libraries should stop depending on them. I don't plan to add them back to RNfW

@necolas where does this information come from? As far as I known it's just about React.PropTypes extracted to prop-types module.

[phpepe]

Hey @mo22, I like your workaround. On which file are you adding this ?

import * as ReactNative from 'react-native-web';
{
 const PropTypes = require('prop-types');
 ReactNative.Text.propTypes = { style: PropTypes.any };
 ReactNative.View.propTypes = { style: PropTypes.any };
 ReactNative.Image.propTypes = { style: PropTypes.any };
 ReactNative.ViewPropTypes = { style: PropTypes.any };
}