Return non-zero exit codes when something goes wrong (WIP) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 27, 2017
lib/pulsar/executor.rb
Outdated
| module Pulsar | ||
| module Executor | ||
| def self.sh(cmd) | ||
| _stdin, _stdout, _stderr, _wait_thr = Open3.popen3(cmd) |
There was a problem hiding this comment.
Do not use prefix _ for a variable that is used.
MinasMazar
force-pushed
the
exit-code
branch
3 times, most recently
from
8d434c4 to
a2b58ad
Compare
houndci-bot
reviewed
Apr 28, 2017
lib/pulsar/cli.rb
Outdated
| @@ -91,5 +104,7 @@ def load_option_or_env!(option) | |||
|
|
|||
| option_value | |||
| end | |||
|
|
|||
| def self.exit_on_failure?; true; end | |||
There was a problem hiding this comment.
private (on line 84) does not make singleton methods private. Use private_class_method or private inside a class << self block instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This close #52
Some references around the web (like this) tells that is a standard to return a value of
0when the command performed successfully and a value different form0otherwise.So this is the
exit_statustable for our project:IMPORTANT
I think this PR will never solve the related issue: there is an unresolvable conflict between
Kernel::exitandsimplecovgem. Maybe the cause is related toat_exitcallback used by simplecov. I noticed many unpredictable weirds behaviors. I tried to keep tests green and full coverage, with many tricks and workarounds but I lost the challenge.NB. The statement with
Kernel::exitmethod is not covered by default by ruby built-in coverage mechanism, so in any case we'll get a100%coverage result when using this method.