Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format unquotted attributes adding quotes to already quoted attributes #42

Closed
IbraheemTuffaha opened this issue Jan 14, 2024 · 2 comments · Fixed by #44
Closed

Format unquotted attributes adding quotes to already quoted attributes #42

IbraheemTuffaha opened this issue Jan 14, 2024 · 2 comments · Fixed by #44

Comments

@IbraheemTuffaha
Copy link
Contributor

The newest release of v0.7.1 by @x4d3 introduced format unquoted attributes.
In some cases, it's adding quotes to attributes that already have quotes, check the image below 👇
image
Seems to me like a weird edge case that needs to be handled.

@phil-janeapp
Copy link
Contributor

phil-janeapp commented Feb 6, 2024

To add some additional context, it appears to be happening on attributes that contain an = sign and are of at least a certain length (somewhere in the 50-60 character range?). I was able to have it happen on <a> tags but only if the URL was of a certain length.

@mikker
Copy link

mikker commented Feb 14, 2024

Happens for this line as well:

- <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
+ <meta name="viewport" content=""width=device-width, initial-scale=1.0, maximum-scale=1.0"">

@elia elia closed this as completed in #44 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants