From bf4fc2d0533529afbea6115961cb784f66de29f6 Mon Sep 17 00:00:00 2001 From: rdjjke Date: Mon, 16 Dec 2024 14:05:56 +0100 Subject: [PATCH] NOTIC: Add rights to manage daemonsets --- config/rbac/role.yaml | 1 + helm/soperator/templates/manager-rbac.yaml | 1 + internal/controller/clustercontroller/reconcile.go | 1 + internal/render/common/configmap.go | 1 - 4 files changed, 3 insertions(+), 1 deletion(-) diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml index 24d7f1fb..56fb8e64 100644 --- a/config/rbac/role.yaml +++ b/config/rbac/role.yaml @@ -39,6 +39,7 @@ rules: - apiGroups: - apps resources: + - daemonsets - deployments - statefulsets verbs: diff --git a/helm/soperator/templates/manager-rbac.yaml b/helm/soperator/templates/manager-rbac.yaml index caca05a3..a788cbab 100644 --- a/helm/soperator/templates/manager-rbac.yaml +++ b/helm/soperator/templates/manager-rbac.yaml @@ -40,6 +40,7 @@ rules: - apiGroups: - apps resources: + - daemonsets - deployments - statefulsets verbs: diff --git a/internal/controller/clustercontroller/reconcile.go b/internal/controller/clustercontroller/reconcile.go index 88e59306..8697070c 100644 --- a/internal/controller/clustercontroller/reconcile.go +++ b/internal/controller/clustercontroller/reconcile.go @@ -67,6 +67,7 @@ import ( //+kubebuilder:rbac:groups=core,resources=serviceaccounts,verbs=get;list;watch;update;patch;delete;create //+kubebuilder:rbac:groups=k8s.mariadb.com,resources=mariadbs,verbs=get;list;watch;update;patch;delete;create //+kubebuilder:rbac:groups=k8s.mariadb.com,resources=grants,verbs=get;list;watch;update;patch;delete;create +//+kubebuilder:rbac:groups=apps,resources=daemonsets,verbs=get;list;watch;update;patch;delete;create // SlurmClusterReconciler reconciles a SlurmCluster object type SlurmClusterReconciler struct { diff --git a/internal/render/common/configmap.go b/internal/render/common/configmap.go index b5e8b335..07af9a67 100644 --- a/internal/render/common/configmap.go +++ b/internal/render/common/configmap.go @@ -266,7 +266,6 @@ func RenderConfigMapSecurityLimits(componentType consts.ComponentType, cluster * func generateUnlimitedSecurityLimitsConfig() renderutils.ConfigFile { res := &renderutils.MultilineStringConfig{} - res.AddLine("#Empty security limits file") res.AddLine("# Set core file size to unlimited (-c)") res.AddLine("* soft core unlimited") res.AddLine("* hard core unlimited")