Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Move Vault secrets and provider auth to custom action #2756

Closed
wants to merge 3 commits into from

Conversation

viniciusdc
Copy link
Contributor

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@marcelovilla
Copy link
Member

@viniciusdc is this ready for review? Is there an associated issue?

@marcelovilla
Copy link
Member

@viniciusdc with Vault failing relatively frequently, I'm wondering if we should consider just using GitHub secrets instead. Any thoughts?

C.C. @Adam-D-Lewis @dcmcand

@dcmcand
Copy link
Contributor

dcmcand commented Nov 6, 2024

I would be in favor of moving away from vault

@marcelovilla
Copy link
Member

I opened #2835

@marcelovilla
Copy link
Member

We're going to address #2835 so we won't be merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants