Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Voila Dashboards work with Voila 0.3.5 #1232

Closed
danlester opened this issue Apr 6, 2022 · 1 comment · Fixed by #1240
Closed

Make Voila Dashboards work with Voila 0.3.5 #1232

danlester opened this issue Apr 6, 2022 · 1 comment · Fixed by #1240
Assignees

Comments

@danlester
Copy link
Contributor

Dashboards don't seem to work with Voila 0.3.5, probably due to new security in Voila.

Something like this might be needed: ideonate/cdsdashboards@148770e

@danlester
Copy link
Contributor Author

I found that if Voilà was run with --preheat_kernel=False (the default, with True being a new feature in ~0.3) then jhsingle-native-proxy's ready-check fetch of the / URL would be connection refused, so we never believe Voilà is running. With --preheat_kernel=True I did not see the same problem.

This must be because the --preheat_kernel=False is not exactly backwards-compatible, although it is possible that increasing the timeout in Simpervisor would get around this (although maybe not for larger notebooks). Anyway, the simpler solution was to change the --ready-check-path=/voila/static/ passed to jhsingle-native-proxy in the Voilà case because that more immediately returns a valid response (albeit a 404).

I have changed this in cdsdashboards and released 0.6.1. When this is available on conda-forge I will update in QHub via a PR.

@trallard trallard moved this to Needs Triage 🔍 in QHub Project Mangement 🚀 Apr 9, 2022
Repository owner moved this from Needs Triage 🔍 to Done 💪🏾 in QHub Project Mangement 🚀 Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants