Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Allow for deploying managed kubernetes within VPC for each cloud provider #1211

Closed
costrouc opened this issue Mar 29, 2022 · 3 comments · Fixed by #1259
Closed

[ENH] - Allow for deploying managed kubernetes within VPC for each cloud provider #1211

costrouc opened this issue Mar 29, 2022 · 3 comments · Fixed by #1259
Assignees
Labels
type: enhancement 💅🏼 New feature or request

Comments

@costrouc
Copy link
Member

Feature description

Related to #1210. In #1210 we are adding support for deploying the load balancer within an existing VPC. However this does not completely solve the problem in that the kubernetes infrastructure itself must also be deployed within the vpc. This is a common issue that we have seen on multiple client deployments. Currently our workaround is to require the client deploys a managed kubernetes cluster and we use the local deployment option to deploy onto the existing kubernetes cluster.

We however do not want to require this. In order to support deploying within an existing vpc we need to add some conditional bits to the 02-infrastructure stage. This will require custom terraform for each provider so I recommend starting with a cloud provider that you are most comfortable with. I'd suggest adding a terraform_overrides key to each providers key. E.g.:

My guess for gcp would be that the qhub-config.yaml would look like:

google_cloud_platform:
    terraform_overrides:
       vpc_id: ....

These overrides would be passed to https://github.com/Quansight/qhub/blob/main/qhub/template/stages/02-infrastructure/gcp/variables.tf.

Value and/or benefit

Ability to deploy qhub within existing VPCs on all cloud providers.

Anything else?

No response

@costrouc costrouc added the type: enhancement 💅🏼 New feature or request label Mar 29, 2022
@costrouc
Copy link
Member Author

costrouc commented Apr 8, 2022

Azure should be a priority for support.

@costrouc
Copy link
Member Author

Azure is not supported with #1253 being closed

Repository owner moved this from Needs Triage 🔍 to Done 💪🏾 in QHub Project Mangement 🚀 Apr 28, 2022
@rsignell-usgs
Copy link
Contributor

Is there an example of how this would look for using existing VPCs on AWS?
We need to do this to deploy Qhub at USGS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants