Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Nebari Logout should also log out of conda-store and grafana #1120

Closed
Tracked by #1309
danlester opened this issue Feb 25, 2022 · 5 comments
Closed
Tracked by #1309

[bug] Nebari Logout should also log out of conda-store and grafana #1120

danlester opened this issue Feb 25, 2022 · 5 comments
Labels
area: integration/conda-store area: integration/grafana area: user experience 👩🏻‍💻 help wanted Extra attention is needed needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug needs: PR 📬 This item has been scoped and needs to be worked on type: bug 🐛 Something isn't working

Comments

@danlester
Copy link
Contributor

danlester commented Feb 25, 2022

If the user clicks Logout within the /hub/home page of Nebari, they are logged out of JupyterHub and Keycloak but not Conda Store or Grafana (and maybe others).

They should be logged out.

Those services should have a /logout endpoint that accepts a redirect_uri query parameter, and then they need to be added to the final_logout_uri chain in Terraform (see input_vars.py how this is already done for Keycloak and tf_extensions).

@trallard trallard added area: user experience 👩🏻‍💻 needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: bug 🐛 Something isn't working labels Feb 25, 2022
@trallard trallard moved this to Needs Triage 🔍 in QHub Project Mangement 🚀 Feb 25, 2022
@magsol magsol added the needs: follow-up 📫 Someone needs to get back to this issue or PR label Mar 31, 2022
@trallard
Copy link
Member

@costrouc is this still a relevant issue or does this need to be closed?

@iameskild iameskild changed the title [bug] QHub Logout should also log out of conda-store and grafana [bug] Nebari Logout should also log out of conda-store and grafana Jun 12, 2023
@pavithraes
Copy link
Member

pavithraes commented Jun 12, 2023

@iameskild just tested this, and this is still as issue for conda-store and grafana. We need to investigate how to resolve this.

@pavithraes pavithraes added area: integration/conda-store needs: PR 📬 This item has been scoped and needs to be worked on help wanted Extra attention is needed area: integration/grafana needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug and removed needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug needs: follow-up 📫 Someone needs to get back to this issue or PR labels Jun 12, 2023
@pavithraes
Copy link
Member

@kcpevey
Copy link
Contributor

kcpevey commented Aug 30, 2023

Just confirmed that after shutting down my server after work yesterday and restarting my computer, I was still logged in to conda-store.

@pavithraes
Copy link
Member

Closing in favour of #2067 :)

@pavithraes pavithraes closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done 💪🏾 in QHub Project Mangement 🚀 Oct 30, 2023
@github-project-automation github-project-automation bot moved this from New 🚦 to Done 💪🏾 in 🪴 Nebari Project Management Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/conda-store area: integration/grafana area: user experience 👩🏻‍💻 help wanted Extra attention is needed needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug needs: PR 📬 This item has been scoped and needs to be worked on type: bug 🐛 Something isn't working
Projects
Development

No branches or pull requests

5 participants