Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI for Create New modal #40

Closed
kcpevey opened this issue May 24, 2024 · 5 comments · Fixed by #69
Closed

Improve UI for Create New modal #40

kcpevey opened this issue May 24, 2024 · 5 comments · Fixed by #69

Comments

@kcpevey
Copy link

kcpevey commented May 24, 2024

Context

When you click "notebook" via "create empty", the modal has a lot of space for "start a new kernel" and very little space for "connect to a running kernel". The "Connect to a running kernel" table has only one line visible.

new-launcher.mov

Value and/or benefit

More balanced UI and improved UX when selecting a "running kernel"

Anything else?

Sidenote - I dont know what "connect to a running kernel" means. Instead of launching new, do I want to just load an already running notebook??

@kcpevey kcpevey changed the title <title> Improve UI for Create New model May 24, 2024
@kcpevey kcpevey changed the title Improve UI for Create New model Improve UI for Create New modal May 24, 2024
@krassowski
Copy link
Member

I dont know what "connect to a running kernel" means. Instead of launching new, do I want to just load an already running notebook?

Yes, this is useful if you want to draft some code in a console side-by-side with notebook:

  • one user flow is to have notebook on the left for noting down the results and console on the right for prototyping code; once a user is happy with a result they drag the cell out of console to the notebook - this way all previous attempts are still tracked, but do not clobber the notebook.
  • another user story is to have one notebook for live data visualisation, and another for the actual model code, open side-by-side connected to the same kernel; this allows you to monitor the results of your models without scrolling back and forth.

@krassowski krassowski added the bug label May 27, 2024
@krassowski
Copy link
Member

While the top table takes up more space, I cannot quite reproduce the bottom table getting down to a single row, neither in Chrome nor in Firefox:

Chrome Firefox
image image

I suspect this state can arise due to delayed rendering with react.

@kcpevey
Copy link
Author

kcpevey commented May 28, 2024

I suspect this state can arise due to delayed rendering with react.

When would this happen? I'm testing on Chrome within Nebari - is that having an effect?

@kcpevey
Copy link
Author

kcpevey commented Aug 22, 2024

Now I'm in a state where the bottom table is reduced down to a tiny sliver. The top table has a scroll bar, but its still taking up too much room.

image

@krassowski
Copy link
Member

Reproduced in Chrome. I had to create at least 40 environments and resize browser window down.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants