Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error to download javascript dependencies with corporate proxy #35

Closed
renaeug opened this issue Jan 26, 2022 · 3 comments
Closed

Error to download javascript dependencies with corporate proxy #35

renaeug opened this issue Jan 26, 2022 · 3 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@renaeug
Copy link

renaeug commented Jan 26, 2022

I'm using version 2.2.0 and the problem is there.

I analyzed #20, but the problem remains, when I test on another non-corporate machine the download is done.

I downloaded it manually and referenced it in mkdocs.yml using extra_javascripts but without success.

can you help? the plugin is excellent! I'm very grateful!

image

image

image

@neatc0der
Copy link
Member

neatc0der commented Jan 28, 2022

Thank you for pointing this out. The trouble concerning proxy is confusing me since a previous migration to requests took place exactly for that reason. Is https://unpkg.com reachable using a browser with your corporate proxy set up?

I can confirm the issue using extra_javascript, though. Analysis shows the config object within this plugin is missing out extra_javascript. I found a solution, but please be aware of this prerequisite:

  • d3.min.js cannot be detected, please adjust to markmap-d3.min.js
  • all static javascript files have to be stored in docs/js, otherwise mkdocs will not copy these files into site/

I'm going to add a corresponding notice to readme.

@neatc0der neatc0der self-assigned this Jan 28, 2022
@neatc0der neatc0der added bug Something isn't working documentation Improvements or additions to documentation labels Jan 28, 2022
neatc0der pushed a commit that referenced this issue Jan 28, 2022
@neatc0der
Copy link
Member

Released v2.2.1

proxy issue still to be discussed

@neatc0der
Copy link
Member

Dead for 6 months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants