Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong feature in cargo #3153

Closed
wants to merge 6 commits into from
Closed

Wrong feature in cargo #3153

wants to merge 6 commits into from

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Aug 12, 2020

runtime-param-estimator features (no-cache, single-thread-rocksdb) was incorrectly included in other crate test. To reproduce, checkout to 8b46df6

cargo clean
cargo test --workspace --no-run
target/debug/near_store_<Tab to auto complete>

Will get a panic indicates no_cache and single_thread_rocksdb feature is incorrectly included.

Test Plan

  • Run 3de84c6 locally, will see above test pass with no panic. Not able to observe this on CI because compile warning treats as error
  • Also whenever single thread rocksdb is enabled it's print that, there was two of that print in ci tests, and expect to see none in this PR's CI

@gitpod-io
Copy link

gitpod-io bot commented Aug 12, 2020

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #3153 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3153      +/-   ##
==========================================
+ Coverage   87.35%   87.44%   +0.08%     
==========================================
  Files         212      212              
  Lines       41525    41525              
==========================================
+ Hits        36274    36311      +37     
+ Misses       5251     5214      -37     
Impacted Files Coverage Δ
chain/network/tests/churn_attack.rs 93.33% <0.00%> (-6.67%) ⬇️
chain/network/tests/routing.rs 98.75% <0.00%> (-1.25%) ⬇️
chain/network/src/peer.rs 80.19% <0.00%> (-0.77%) ⬇️
chain/client/tests/process_blocks.rs 90.52% <0.00%> (-0.45%) ⬇️
chain/chain/src/doomslug.rs 99.22% <0.00%> (-0.26%) ⬇️
chain/network/src/peer_manager.rs 82.88% <0.00%> (-0.26%) ⬇️
neard/tests/rpc_nodes.rs 96.69% <0.00%> (-0.24%) ⬇️
chain/network/src/routing.rs 92.81% <0.00%> (-0.20%) ⬇️
chain/chain/src/store.rs 86.33% <0.00%> (-0.17%) ⬇️
chain/client/src/client_actor.rs 84.97% <0.00%> (-0.15%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c4489...25ecc6b. Read the comment docs.

@ailisp
Copy link
Member Author

ailisp commented Nov 18, 2020

This is solved by putting runtime-params-estimator to [ignore] section, found by @evgenykuzyakov

@ailisp ailisp closed this Nov 18, 2020
@Ekleog-NEAR Ekleog-NEAR deleted the wrong-feature-in-cargo branch March 29, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant