fix(chain): do not return error on get_gc_stop_height #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
|
|
bowenwang1996
force-pushed
the
fix-gc-stop-height-bug
branch
from
07222d6 to
37afd2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3144 +/- ##
==========================================
- Coverage 87.49% 87.31% -0.18%
==========================================
Files 212 212
Lines 41463 41424 -39
==========================================
- Hits 36277 36169 -108
- Misses 5186 5255 +69
Continue to review full report at Codecov.
|
SkidanovAlex
approved these changes
Aug 12, 2020
bowenwang1996
added a commit
that referenced
this pull request
Aug 12, 2020
Currently when we do not have enough blocks for garbage collection, `get_gc_stop_height` will return a `DBNotFoundErr` and the caller handles the error. This caused an incorrect handling of error in `process_block` and we will reject valid blocks if we do not have enough data for garbage collection, which can happen after a state sync. This PR changes `get_gc_stop_height` to return genesis height when we do not have enough data for garbage collection and therefore we don't need to worry about error handling at call site. Test plan --------- * `test_process_block_after_state_sync`
bowenwang1996
added a commit
that referenced
this pull request
Aug 13, 2020
Currently when we do not have enough blocks for garbage collection, `get_gc_stop_height` will return a `DBNotFoundErr` and the caller handles the error. This caused an incorrect handling of error in `process_block` and we will reject valid blocks if we do not have enough data for garbage collection, which can happen after a state sync. This PR changes `get_gc_stop_height` to return genesis height when we do not have enough data for garbage collection and therefore we don't need to worry about error handling at call site. Test plan --------- * `test_process_block_after_state_sync`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we do not have enough blocks for garbage collection,
get_gc_stop_heightwill return aDBNotFoundErrand the caller handles the error. This caused an incorrect handling of error inprocess_blockand we will reject valid blocks if we do not have enough data for garbage collection, which can happen after a state sync. This PR changesget_gc_stop_heightto return genesis height when we do not have enough data for garbage collection and therefore we don't need to worry about error handling at call site.Test plan
test_process_block_after_state_sync