Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network_drop_package.py is flaky: times out #3135

Closed
SkidanovAlex opened this issue Aug 11, 2020 · 0 comments · Fixed by #3210
Closed

network_drop_package.py is flaky: times out #3135

SkidanovAlex opened this issue Aug 11, 2020 · 0 comments · Fixed by #3210
Assignees
@mfornet
Labels
A-chain Area: Chain, client & related

Comments

@SkidanovAlex
Copy link
Collaborator

A regular run takes 20 seconds, and the timeout is three minutes, so the timeouts are not due to the timeout being too small.

http://52.149.162.182:3000/#/test/7273
http://52.149.162.182:3000/#/test/4873
@SkidanovAlex SkidanovAlex added the A-chain Area: Chain, client & related label Aug 11, 2020
@mfornet mfornet self-assigned this Aug 14, 2020
@weekly-digest weekly-digest bot mentioned this issue Aug 14, 2020
Closed
@mfornet mfornet mentioned this issue Aug 18, 2020
Merged
nearprotocol-bulldozer bot pushed a commit that referenced this issue Aug 25, 2020
@mfornet
fix(network_drop_package): Process was starving (#3210)
5e048de 
Add time.sleep(0) to allow other process to make progress.
Reproducing the issue is hard, so there is a chance this doesn't
fix it. In that case it is possible to use time.sleep(eps) but it
leads to a suboptimal experience where we need to wait `eps` timeout
for every message passing through the proxy.

Fixes #3135 

Test plan
=========
network_drop_package.py should pass

Success. http://nayduck.eastus.cloudapp.azure.com:3000/run/214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfornet mfornet

Labels
A-chain Area: Chain, client & related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(network_drop_package): Process was starving near/nearcore
2 participants
@SkidanovAlex @mfornet