Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether param estimator is affected by disk caching #3097

Closed
Tracked by #5995
MaksymZavershynskyi opened this issue Aug 7, 2020 · 7 comments
Closed
Tracked by #5995
Assignees
Labels
A-contract-runtime Area: contract compilation and execution, virtual machines, etc T-contract-runtime Team: issues relevant to the contract runtime team

Comments

@MaksymZavershynskyi
Copy link
Contributor

As reported by @SkidanovAlex Ubuntu can cache up to 1GiB of disk, we need to make sure param estimator is hitting the actual disk and not the cache.

@MaksymZavershynskyi MaksymZavershynskyi added A-testing Area: Unit testing / integration testing A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) labels Aug 7, 2020
@MaksymZavershynskyi MaksymZavershynskyi removed the A-testing Area: Unit testing / integration testing label Aug 7, 2020
@bowenwang1996 bowenwang1996 added A-contract-runtime Area: contract compilation and execution, virtual machines, etc T-contract-runtime Team: issues relevant to the contract runtime team and removed A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) labels Jun 29, 2021
@bowenwang1996
Copy link
Collaborator

@olonho what is the status of this issue?

@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Sep 27, 2021
@bowenwang1996
Copy link
Collaborator

@matklad @olonho

@stale stale bot removed the S-stale label Sep 27, 2021
@matklad
Copy link
Contributor

matklad commented Sep 29, 2021

No progress here, good to keep in mind though. #4771 feels related as vaguely database-related issue which

@stale
Copy link

stale bot commented Dec 28, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 4, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Apr 4, 2022
@jakmeier
Copy link
Contributor

jakmeier commented Apr 7, 2022

Closing this since we merged #6347.

Summary: Yes we are affected by disk caching. We can get around it now by adding --drop-os-cache but it requires root. Long-term plan is to have a more separate IO estimation step but for the moment this is good enough to get estimations that are not affected by disk cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contract-runtime Area: contract compilation and execution, virtual machines, etc T-contract-runtime Team: issues relevant to the contract runtime team
Projects
None yet
Development

No branches or pull requests

6 participants