Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate bridge failure #3049

Closed
MaksymZavershynskyi opened this issue Jul 27, 2020 · 5 comments
Closed

Investigate bridge failure #3049

MaksymZavershynskyi opened this issue Jul 27, 2020 · 5 comments
Assignees

Comments

@MaksymZavershynskyi
Copy link
Contributor

As discussed in Near-One/rainbow-bridge#217 as of one week ago the bridge contracts sometimes reject headers and proofs coming from the nodes. And can be a sign that nearcore headers and proofs are not consistent with the format that the code was using a week ago, which might be a sign of an unintended breakage. We need to resolve this issue before launching Phase 1.

@MaksymZavershynskyi
Copy link
Contributor Author

Me and @ailisp are working on extracting reproducible tests. So far it is flaky and only manifests on the CI machines.

@ailisp
Copy link
Member

ailisp commented Jul 28, 2020

I got an repro from logs in this: https://buildkite.com/nearprotocol/rainbow-bridge/builds/418#ee325a11-df0b-4425-8b17-b0f2ba8ce089

repro steps:

  1. checkout to Fix invalid proof error in ci e2e Near-One/rainbow-bridge#227
  2. yarn test in libs-sols/nearprover

@MaksymZavershynskyi
Copy link
Contributor Author

@bowenwang1996 here is a reproducible light client issue.

@ailisp
Copy link
Member

ailisp commented Jul 28, 2020

My repro is wrong, it fail because missing bridge.blockMerkleRoots[406]. In ci e2e, bridge.blockMerkleRoots[406] do exist but doesn't match prover's (line 48 of NearProver.sol). Still need to output that info from bridge side to make a correct repro

@ailisp
Copy link
Member

ailisp commented Jul 28, 2020

Found a correct repro and fixed in Near-One/rainbow-bridge#227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants