Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

TODO: Update to modern ES6/ES7/ESnext and Fastify #3

Open
5 tasks done
jasnell opened this issue Jun 10, 2018 · 6 comments
Open
5 tasks done

TODO: Update to modern ES6/ES7/ESnext and Fastify #3

jasnell opened this issue Jun 10, 2018 · 6 comments

Comments

@jasnell
Copy link

jasnell commented Jun 10, 2018

@robbdempsey

The Acmeair sample was first written in 2015 and has not been updated in some time. It would be good to have a "modern" version of the sample.

  • Use Fastify (WIP: Fastify #2)
  • Use Promises / async/await where possible - The current code makes extensive use of callbacks.
  • Use Pino for logging - The current code uses log4j
  • Update dependencies
  • Identify and Improve performance bottlenecks

/cc @conoro @dberesford @mcollina

This was referenced Jun 26, 2018
@robbdempsey
Copy link

@jasnell when #7 lands I'm not sure what else can be done here. I have another issue to work on related to clinic that I'm going to shift too. if you have ideas on what to do next let me know.

@jasnell
Copy link
Author

jasnell commented Jun 29, 2018

@robbdempsey ... Thank you very much for the work on this. Excellent stuff.

@robbdempsey
Copy link

@jasnell do you want me to PR this upstream in acmeair?

@jasnell
Copy link
Author

jasnell commented Aug 20, 2018 via email

@robbdempsey
Copy link

@jasnell

acmeair#20

@mcollina
Copy link

@robbdempsey it would be good to include some basic improvements done in that PR to show how more performant is now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants