Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing npm after git spawn change #247

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

matijagaspar
Copy link
Contributor

@matijagaspar matijagaspar commented Jan 18, 2023

Fixes: #248

The issue was that:

const code = await exec(cmd, args, options)

Will throw an error if it fails to execute and the error will not contain the console output of the exec. I wrapped the bit into a try catch, so the underlying console output can be collected and put into the error message that is later handled by the outer function

Copy link
Contributor

@sameer-coder sameer-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matijagaspar matijagaspar merged commit bccff8e into main Jan 18, 2023
@matijagaspar matijagaspar deleted the fix/fix-failing-npm-after-git-spawn-change branch January 18, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action consistently fails to execute
3 participants