Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor runSpawn to use @actions/exec (#205)" #208

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Revert "refactor runSpawn to use @actions/exec (#205)" #208

merged 1 commit into from
Dec 16, 2022

Conversation

maksimovicdanijel
Copy link
Contributor

This reverts commit 66727ac.

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@maksimovicdanijel maksimovicdanijel marked this pull request as ready for review December 16, 2022 11:18
simoneb
simoneb approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double check that this really only reverts your changes and nothing else before merging

@maksimovicdanijel
Copy link
Contributor Author

please double check that this really only reverts your changes and nothing else before merging

Yes, these were the changes I made. It looks good 👍

@maksimovicdanijel maksimovicdanijel merged commit d8b9ae5 into main Dec 16, 2022
@maksimovicdanijel maksimovicdanijel deleted the fix/revert-exec-refactor branch December 16, 2022 11:25
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksimovicdanijel @simoneb