Prevent running server on exposed network address

[agostbiro]

When I run the workspace as part of an integration test I get this popup on the latest MacOS:

This indicates that the server tries to listen on an exposed network address. Ideally, the server would only run on localhost by default and then this popup wouldn't show.

A quick look at the source shows that the default address is indeed localhost:

pub const DEFAULT_RPC_URL: &str = "http://localhost";

so there must be something weird going on to get this popup.

Happy to dig in and provide a PR if you think it's important.

[frol]

@agostbiro Good catch. Yeah, it is indeed annoying and it is better to solve it. I believe it is not RPC that is not running on localhost, but the P2P part of neard. Workspaces-rs sandbox launches neard server and neard uses two TCP ports: (1) RPC, (2) p2p network. Workspaces-rs patches the config to specify the proper RPC IP:address:

https://github.com/near/workspaces-rs/blob/c31a955df8a55a6c82cedaaf820ed9236ee1fee5/workspaces/src/network/server.rs#L100

My guess is that it does not patch the network addr (I see that it seems to patch the port)

Please, address it.

[agostbiro]

Thanks @frol , that was helpful! It turns out that there were two separate causes for the popups, so it was a bit involved to track them down, but the fix is in now: #277

[frol]

Resolved in #277