Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jsonrpc): Refactor broadcast_tx jsonrpc handler to add structured errors #4180

Merged
merged 9 commits into from
Apr 13, 2021
Merged

refactor(jsonrpc): Refactor broadcast_tx jsonrpc handler to add structured errors #4180

merged 9 commits into from
Apr 13, 2021

Commits on Apr 12, 2021

  1. Refactor broadcast_tx jsonrpc handler to add structurred errors

    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    f86e499 View commit details
    Browse the repository at this point in the history

  2. Remove wip comments

    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ff5d8bf View commit details
    Browse the repository at this point in the history

  3. Refactor tx_status_common, move impl From<NetworkClientResponses> to … 

    …jsonrpc to avoid near_network dependency in jsonrpc-primitives
    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    31a14c7 View commit details
    Browse the repository at this point in the history

  4. Return error in case of NetworkClientResponses::RequestRouted, return… 

    … same result on check_tx and send_tx_sync
    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c6aca35 View commit details
    Browse the repository at this point in the history

  5. Make backward compatible error messages to refactored methods. Make c… 

    …orresponding tests pass
    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    12aa083 View commit details
    Browse the repository at this point in the history

  6. Move backward compatibility to jsonrpc-primitives from jsonrpc, move … 

    …ServerError from jsonrpc to jsonrpc-primitives, fix dependencies
    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    e2aec7f View commit details
    Browse the repository at this point in the history

  7. Address review suggestions

    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    4b6a4e3 View commit details
    Browse the repository at this point in the history

  8. Address review suggestions. Update jsonrpc changelog, bump version

    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    9d080c2 View commit details
    Browse the repository at this point in the history

  9. Address review suggestions

    @khorolets
    khorolets committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    3d1b5e9 View commit details
    Browse the repository at this point in the history