feat: Add ability to import methods guarded by protocol feature #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Jan 20, 2021
ailisp
reviewed
Jan 20, 2021
| @@ -264,4 +277,7 @@ wrapped_imports! { | |||
| // ############### | |||
| validator_stake<[account_id_len: u64, account_id_ptr: u64, stake_ptr: u64] -> []>, | |||
| validator_total_stake<[stake_ptr: u64] -> []>, | |||
| // ############### | |||
| // An example to add a protocol feature guarded host method | |||
| // #["protocol_feature_evm", EVM] test_api<[a: u64] -> []>, | |||
There was a problem hiding this comment.
This example seems to be confusing, as evm is not executed in near-vm-runner. Should we use another information here?
Also, consider add a test to guarded api?
There was a problem hiding this comment.
Yes. The test is here: #3827
But I need to compile a contract with this import and check that it fails to run in the previous protocol version and runs in the new protocol version.
We can do this for a real new import. For example burn_near
ailisp
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
wrapped_importmacro to add an ability to introduce new host methods.This change doesn't modify the protocol.
Test plan: