fix: address slowness in block sync #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bowenwang1996
commented
Sep 20, 2020
| let close_to_header_head = | ||
| last_header.height() > header_head.height.saturating_sub(self.block_fetch_horizon); | ||
| if self.cache.len() < BLOCK_SYNC_CACHE_LOWER_LIMIT || close_to_header_head { | ||
| if (self.cache.len() as u64) < self.block_fetch_horizon { |
There was a problem hiding this comment.
@SkidanovAlex I think this will make the node more susceptible to eclipse attacks. To address this, we can attempt to check whether the last header is on the same chain as header head, but I don't think it's worth spending the time to polish it, given that we will likely change this code completely.
SkidanovAlex
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3241 introduced an issue during block sync: it maintains
last_block_headeras the block header with largest height in the cache and has this logic that checks whether it is sufficiently close to header head and if it is, then the cache is ignored. However, the issue is that the sync loop runs every 10ms and therefore, it is almost always the case that this condition is triggered and the cache is effectively ignored. This PR fixes it by removing the condition.Test plan
Sync a node to testnet with this change and observe major improvements in syncing speed.