fix(proxy_restart): Consistent way to restart nodes with proxy #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mfornet
changed the title
| @@ -326,6 +327,10 @@ def proxify_node(node, ps, handler, global_stopped, error, proxy): | |||
| outer_port = inner_port + 100 | |||
|
|
|||
| def start_proxy(): | |||
| # local_stopped denotes the current of state of the proxy: | |||
| # 0: The proxy is running | |||
| # 1: The proxy is running but should be closed soon | |||
There was a problem hiding this comment.
To kill a node, this value is set to 1 so the underlying proxy finishes
https://github.com/nearprotocol/nearcore/blob/master/pytest/lib/cluster.py#L343
Codecov Report
@@ Coverage Diff @@
## master #3272 +/- ##
=======================================
Coverage 87.22% 87.22%
=======================================
Files 217 217
Lines 42397 42397
=======================================
Hits 36981 36981
Misses 5416 5416 Continue to review full report at Codecov.
|
SkidanovAlex
approved these changes
Sep 3, 2020
SkidanovAlex
reviewed
Sep 3, 2020
bowenwang1996
approved these changes
Sep 3, 2020
mhalambek
pushed a commit
that referenced
this pull request
Sep 7, 2020
On proxy restart wait for the previous instance to get closed before starting a new one fixes #3134 Test plan ======= sanity/proxy_restart.py pass consistently http://nayduck.eastus.cloudapp.azure.com:3000/#/run/285
chefsale
pushed a commit
that referenced
this pull request
Sep 7, 2020
On proxy restart wait for the previous instance to get closed before starting a new one fixes #3134 Test plan ======= sanity/proxy_restart.py pass consistently http://nayduck.eastus.cloudapp.azure.com:3000/#/run/285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On proxy restart wait for the previous instance to get closed before starting a new one
fixes #3134
Test plan
sanity/proxy_restart.py pass consistently
http://nayduck.eastus.cloudapp.azure.com:3000/#/run/285