fix(sync): avoid unnecessary block hash fetching during block sync #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3241 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 216 216
Lines 44711 44711
=======================================
Hits 39242 39242
Misses 5469 5469 Continue to review full report at Codecov.
|
bowenwang1996
force-pushed
the
fix-block-sync1
branch
from
3a9f6a6 to
d7f61e6
Compare
bowenwang1996
force-pushed
the
fix-block-sync1
branch
from
d7f61e6 to
cfacc1a
Compare
| break; | ||
| } | ||
| let block_exists = chain.block_exists(block_hash).unwrap_or(false); | ||
| if block_exists { |
There was a problem hiding this comment.
why only if it exists, but not if it's an orphan?
There was a problem hiding this comment.
added a comment
SkidanovAlex
approved these changes
Aug 28, 2020
This was referenced Aug 29, 2020
bowenwang1996
added a commit
that referenced
this pull request
Sep 3, 2020
…3241) Currently on every iteration of block sync we would recompute the hashes of blocks that we need to sync, which is extremely slow when the amount of blocks that we need to sync is large. This PR fixes it by caching the hashes and only update it when we are close to syncing all the blocks in the cache. Test plan ----------- * `test_block_sync` * Run nightly tests * Test it on testnet.
bowenwang1996
added a commit
that referenced
this pull request
Sep 7, 2020
…3241) Currently on every iteration of block sync we would recompute the hashes of blocks that we need to sync, which is extremely slow when the amount of blocks that we need to sync is large. This PR fixes it by caching the hashes and only update it when we are close to syncing all the blocks in the cache. Test plan ----------- * `test_block_sync` * Run nightly tests * Test it on testnet.
bowenwang1996
added a commit
that referenced
this pull request
Sep 22, 2020
#3241 introduced an issue during block sync: it maintains `last_block_header` as the block header with largest height in the cache and has this logic that checks whether it is sufficiently close to header head and if it is, then the cache is ignored. However, the issue is that the sync loop runs every 10ms and therefore, it is almost always the case that this condition is triggered and the cache is effectively ignored. This PR fixes it by removing the condition. Test plan --------- Sync a node to testnet with this change and observe major improvements in syncing speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on every iteration of block sync we would recompute the hashes of blocks that we need to sync, which is extremely slow when the amount of blocks that we need to sync is large. This PR fixes it by caching the hashes and only update it when we are close to syncing all the blocks in the cache.
Test plan
test_block_sync