fix: correctly verify gas price #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
|
|
evgenykuzyakov
approved these changes
Aug 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #3154 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 212 212
Lines 41554 41554
=======================================
Hits 36312 36312
Misses 5242 5242 Continue to review full report at Codecov.
|
SkidanovAlex
approved these changes
Aug 13, 2020
bowenwang1996
added a commit
that referenced
this pull request
Aug 13, 2020
Currently there is a discrepancy between how gas price is computed and how it is verified. This leads to verification failure when the protocol changes between epochs. Test plan --------- `test_gas_price_change_no_chunk`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a discrepancy between how gas price is computed and how it is verified. This leads to verification failure when the protocol changes between epochs.
Test plan
test_gas_price_change_no_chunk