Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to cover stress.py fails #3089

Closed
wants to merge 3 commits into from
Closed

add test to cover stress.py fails #3089

wants to merge 3 commits into from

Conversation

pmnoxx
Copy link
Contributor

@pmnoxx pmnoxx commented Aug 5, 2020 •
edited
Loading

Add a new test, which should. detect failures fixed in #3036

Adds test for #3036

@gitpod-io
Copy link

gitpod-io bot commented Aug 5, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Aug 6, 2020 •
edited
Loading

Codecov Report

Merging #3089 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3089   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files         213      213           
  Lines       41680    41680           
=======================================
  Hits        36513    36513           
  Misses       5167     5167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac134c3...e277e75. Read the comment docs.

@pmnoxx pmnoxx force-pushed the piotr-test-liveness-if-block-doesnt-get-distributed branch from f9e9ba6 to cb38ce3 Compare August 6, 2020 00:15
@weekly-digest weekly-digest bot mentioned this pull request Aug 7, 2020
Closed
SkidanovAlex
SkidanovAlex reviewed Aug 11, 2020
View reviewed changes
pytest/xx.py Outdated Show resolved Hide resolved
pytest/tests/sanity/proxy_loose_block_messages.py Outdated Show resolved Hide resolved
pytest/tests/sanity/proxy_loose_block_messages.py Outdated Show resolved Hide resolved
@pmnoxx pmnoxx force-pushed the piotr-test-liveness-if-block-doesnt-get-distributed branch 3 times, most recently from 9606a8d to 3514426 Compare August 11, 2020 08:11
@pmnoxx pmnoxx marked this pull request as ready for review August 11, 2020 08:47
@weekly-digest weekly-digest bot mentioned this pull request Aug 14, 2020
Closed
@pmnoxx pmnoxx mentioned this pull request Aug 18, 2020
Open
@pmnoxx pmnoxx self-assigned this Jan 29, 2021
@stale
Copy link

stale bot commented Jul 1, 2021

This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks.
It will be closed in 3 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 1, 2021
@bowenwang1996
Copy link
Collaborator

@pmnoxx @SkidanovAlex what is the status of this PR?

@stale stale bot removed the S-stale label Jul 1, 2021
@stale
Copy link

stale bot commented Jul 15, 2021

This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks.
It will be closed in 3 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 15, 2021
@pmnoxx pmnoxx force-pushed the piotr-test-liveness-if-block-doesnt-get-distributed branch from e277e75 to 9eb3f3a Compare November 12, 2021 03:40
@stale stale bot removed the S-stale label Nov 12, 2021
@pmnoxx
Copy link
Contributor Author

pmnoxx commented Nov 12, 2021 •
edited
Loading

http://nayduck.near.org/#/run/2205

@pmnoxx pmnoxx force-pushed the piotr-test-liveness-if-block-doesnt-get-distributed branch from 1aa8617 to 9ed6bb5 Compare November 12, 2021 03:51
@pmnoxx pmnoxx requested a review from mm-near November 12, 2021 03:57
mm-near
mm-near suggested changes Nov 12, 2021
View reviewed changes
pytest/tests/sanity/proxy_loose_block_messages.py
ignored_messages = set()
max_height = Value('i', 0)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain what this test does?

@pmnoxx pmnoxx closed this Nov 16, 2021
@Ekleog-NEAR Ekleog-NEAR deleted the piotr-test-liveness-if-block-doesnt-get-distributed branch March 29, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkidanovAlex SkidanovAlex SkidanovAlex left review comments

@mm-near mm-near mm-near requested changes

Assignees

@pmnoxx pmnoxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmnoxx @bowenwang1996 @SkidanovAlex @mm-near