Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonrpc): Fixed race condition in broadcast_tx_* methods #3061

Merged

Conversation

frol
Copy link
Collaborator

@frol frol commented Jul 30, 2020

Resolves #3054.

Test Plan

Manually confirmed that the benchmark works fine and the node does not report incorrect nonce.

@frol frol requested a review from evgenykuzyakov as a code owner July 30, 2020 21:29
@gitpod-io
Copy link

gitpod-io bot commented Jul 30, 2020

@frol frol force-pushed the fix-broadcast-tx-race-condition-invalid-nonce branch from 05c016b to 57c23bb Compare July 30, 2020 21:49
@frol frol added the automerge label Jul 30, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #3061 into master will decrease coverage by 0.05%.
The diff coverage is 22.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
- Coverage   87.47%   87.42%   -0.06%     
==========================================
  Files         212      212              
  Lines       41121    41150      +29     
==========================================
+ Hits        35971    35975       +4     
- Misses       5150     5175      +25     
Impacted Files Coverage Δ
chain/jsonrpc/src/lib.rs 61.81% <22.58%> (-3.21%) ⬇️
chain/client/src/test_utils.rs 87.45% <0.00%> (-4.07%) ⬇️
chain/network/src/test_utils.rs 90.32% <0.00%> (-1.62%) ⬇️
core/store/src/trie/state_parts.rs 95.77% <0.00%> (-1.41%) ⬇️
chain/network/src/peer.rs 79.57% <0.00%> (-1.35%) ⬇️
chain/client/src/types.rs 67.50% <0.00%> (-1.25%) ⬇️
chain/client/src/client_actor.rs 84.39% <0.00%> (-0.75%) ⬇️
neard/tests/rpc_nodes.rs 96.69% <0.00%> (-0.24%) ⬇️
chain/chain/src/chain.rs 88.45% <0.00%> (-0.22%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f816d09...57c23bb. Read the comment docs.

@nearprotocol-bulldozer nearprotocol-bulldozer bot merged commit 33befb9 into master Jul 30, 2020
@nearprotocol-bulldozer nearprotocol-bulldozer bot deleted the fix-broadcast-tx-race-condition-invalid-nonce branch July 30, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looks like broadcast_tx_commit sometimes returns nonce error erroneously
3 participants