fix(chain): always use the right chunk extra when producing chunks #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
ailisp,
evgenykuzyakov,
frol,
MaksymZavershynskyi,
olonho and
SkidanovAlex
as code owners
|
|
bowenwang1996
force-pushed
the
fix-chunk-extra-bug
branch
from
f477bef to
2d8703a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3056 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 212 212
Lines 44778 44778
=======================================
Hits 39574 39574
Misses 5204 5204 Continue to review full report at Codecov.
|
SkidanovAlex
approved these changes
Jul 29, 2020
ailisp
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always use latest chunk extra when producing chunks. However, this might cause problems because the latest chunk extra is determined by the current head, which might not be the block that we are producing chunk on top of. When this happens, it causes invalid chunks to be produced, as mentioned in #3055. This PR fixes it by always using the chunk extra from the block that the chunk is building on. Fixes #3055.
Test plan
test_validate_chunk_extra