Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement structured errors in view-client #3518

Closed
frol opened this issue Oct 22, 2020 · 2 comments
Closed

Implement structured errors in view-client #3518

frol opened this issue Oct 22, 2020 · 2 comments
Assignees
@khorolets
Labels
A-chain Area: Chain, client & related C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@frol
Copy link
Collaborator

frol commented Oct 22, 2020

It is the first iteration of #3204 (+ #3517).

We need to rebase #3204 to the point that the view-client errors are just Debug-formatted into the old error message field on the JSON RPC side. Don't merge the PR since it is not backwards compatible. @khorolets or I will take it from there and finish the compatibility of the messages with our old implementation as part of #3517.
@frol frol added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-chain Area: Chain, client & related labels Oct 22, 2020
@frol frol mentioned this issue Oct 22, 2020
Closed
2 tasks
@frol frol assigned khorolets and unassigned bowenwang1996 Jan 7, 2021
@frol frol mentioned this issue Jan 25, 2021
Closed
@frol
Copy link
Collaborator Author

frol commented Jan 27, 2021

Status Update: #3805 paved the road to implement this, however, we decided to move in smaller steps and leave the grand errors refactoring (#3851) for later.

@frol frol mentioned this issue Jan 27, 2021
Closed
@frol
Copy link
Collaborator Author

frol commented May 1, 2021

Resolved in #3805

@frol frol closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khorolets khorolets

Labels
A-chain Area: Chain, client & related C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frol @khorolets @bowenwang1996