Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bootnodes config validation #1655

Closed
lexfrl opened this issue Nov 6, 2019 · 8 comments
Closed

Add a bootnodes config validation #1655

lexfrl opened this issue Nov 6, 2019 · 8 comments
Labels
B-L2 Bootcamp: (“Bug Fix”) minor 10-20 code line change C-enhancement Category: An issue proposing an enhancement or a PR with one. C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. Node Node team T-node Team: issues relevant to the node experience team
Milestone

Comments

@lexfrl
Copy link
Contributor

lexfrl commented Nov 6, 2019

Add a bootnode config validation. account_id cannot be Some("34.89.175.66 :24567") and address must be defined.

[2019-11-06T11:06:42Z WARN near_network::peer_manager] Trying to connect to peer with no public address: PeerInfo { id: ed25519:FF7ttcBjsyNtXh6fBw5q85o2HYgtPxnC36Xhvt3HYb8X, addr: None, account_id: Some("34.89.175.66 :24567") }

@lexfrl lexfrl changed the title Add a bootnode config validation Add a bootnodes config validation Nov 6, 2019
@ilblackdragon ilblackdragon added this to the MainNet milestone Dec 8, 2019
@ilblackdragon ilblackdragon added the C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. label Mar 20, 2020
@ilblackdragon ilblackdragon modified the milestones: MainNet, Post MainNet Mar 20, 2020
@frol frol added bootcamp C-enhancement Category: An issue proposing an enhancement or a PR with one. T-public-interfaces Team: issues relevant to the public interfaces team B-L2 Bootcamp: (“Bug Fix”) minor 10-20 code line change labels Jun 3, 2021
@janewang janewang added the T-node Team: issues relevant to the node experience team label Jun 18, 2021
@janewang
Copy link

janewang commented Jul 6, 2021

@chefsale Are you working on this already? Please let us know. Thanks!

@janewang janewang removed the T-public-interfaces Team: issues relevant to the public interfaces team label Jul 6, 2021
@chefsale
Copy link
Contributor

chefsale commented Jul 7, 2021

I haven't started working on this, I just added th boot nodee to the init command. Is this urgent, if yes I can takr it over.

@bowenwang1996
Copy link
Collaborator

Is this urgent

No it is not urgent. Just want to make sure that it is still relevant

@stale
Copy link

stale bot commented Oct 5, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Oct 5, 2021
@chefsale chefsale removed the S-stale label Oct 6, 2021
@Rishabhraghwendra18
Copy link
Contributor

@bowenwang1996 @janewang I will like to work on this issue . May you guide me what changes I have to make in which file to solve this issue ?

@bowenwang1996
Copy link
Collaborator

I think it is about making sure that the ip address can be properly parsed. Actually it seems that this has already been fixed. @Rishabhraghwendra18 maybe you can help verify that

@Rishabhraghwendra18
Copy link
Contributor

@bowenwang1996 yup sure... I think you are correct it has been implemented . I have found this PR which talks about boot_address . It made the changes to extract the address inside a function (as per the PR description)

@bowenwang1996
Copy link
Collaborator

@Rishabhraghwendra18 thanks! closing this issue as it is already implemented

@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-L2 Bootcamp: (“Bug Fix”) minor 10-20 code line change C-enhancement Category: An issue proposing an enhancement or a PR with one. C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. Node Node team T-node Team: issues relevant to the node experience team
Projects
None yet
Development

No branches or pull requests

8 participants