Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests erroring out on newest rust v1.63.0 #177

Merged
merged 1 commit into from
Aug 12, 2022
Merged

fix: tests erroring out on newest rust v1.63.0 #177

merged 1 commit into from
Aug 12, 2022

Conversation

ChaoticTempest
Copy link
Member

This fixes the current builds failing with the release of 1.63.0 with newer clippy warnings.

  • also bumped MSRV to 1.60 since near-primitives 0.14 requires it.

itegulov
itegulov approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was about to ask why our CI had not failed earlier, but then I saw that we never used MSRV in the pipeline.

@ChaoticTempest ChaoticTempest merged commit 18c24a4 into main Aug 12, 2022
@ChaoticTempest ChaoticTempest deleted the fix/latest-rs-1.63 branch August 12, 2022 15:53
ChaoticTempest added a commit that referenced this pull request Aug 16, 2022
@ChaoticTempest
Fix tests erroring out on newest rust v1.63.0 (#177)
f4c5e15
@frol frol mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@itegulov itegulov itegulov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaoticTempest @itegulov @austinabell